Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Oct 20, 2020

No description provided.

@ghost ghost requested a review from fabubaker October 20, 2020 01:04
python3 tcga_fpkm_dendrogram.py <filename>
```

A folder called `results` will be created which will contain the following output files:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you list the generated output files and give a brief description of them here?

@@ -0,0 +1,53 @@
# TCGA_FPKM_dendrogram
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we want this script to be a generic dendogram + PCA clustering script, not necessarily focused on the TCGA data set. So it's best not to mention TCGA in the documentation or in the code.

Once you have activated the `virtualenv`, use the script as follows:

```bash
python3 tcga_fpkm_dendrogram.py <filename>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a brief description of the how the input file should look like? Maybe a small example as well?

Comment on lines +36 to +41
def plot_dendro_interactive(data, labels):
data_array = tcga_data.to_numpy()
fig = ff.create_dendrogram(data_array, orientation='left', labels=labels)
fig.update_layout(width=1600, height=800)
fig.write_image('./results/TCGA-FPKM_dendrogram-intr.png')
fig.show()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well remove this function since it's no longer used.

@@ -0,0 +1,96 @@
from sklearn.cluster import AgglomerativeClustering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to remove all mentions of TCGA.

sys.exit()

# Create directory for results
path = './results'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a parameter for the user to specify the name of the output directory?

@fabubaker fabubaker changed the title Upload dendrogram generating script Upload dendrogram + PCA clustering script Nov 24, 2020
@fabubaker fabubaker assigned ghost Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants